add first class mixins to embedded sass protobuf and JS API #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Sep 13, 2023
|
We should bump the version number in https://github.com/sass/sass/blob/main/spec/EMBEDDED_PROTOCOL_VERSION |
|
As this creates a new kind of value that can be sent to the host, is it actually a minor version or a major one ? |
|
Historically this kind of change has been considered as minor. The host can upgrade to new protocol version without supporting added type, and all previous feature would still work. |
nex3
approved these changes
Sep 28, 2023
This was referenced Sep 29, 2023
connorskees
force-pushed
the
feat/first-class-mixin-proto
branch
3 times, most recently
from
26a6ae5
to
f326753
Compare
connorskees
force-pushed
the
feat/first-class-mixin-proto
branch
from
f326753
to
8998009
Compare
|
This looks good! Only thing is that we should probably edit the title of this PR as the scope of this PR has increased. |
connorskees
changed the title
nex3
approved these changes
Oct 4, 2023
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Oct 12, 2023
* main: Remove `isAlphaMissing` and add "alpha" to channel name types. Rename types using title-case for acronyms longer than two letters in camel-case identifiers. Clarifying performance expectations about sass and sass-embedded (sass#3716) Tweak language around getters and arrays. Code review Remove unused ValueObject type [First-Class Mixins] Flush to spec Move and restructure how we specify scopes Fix typos in the deprecation APi proposal (sass#3708) Return immutable types Remove generic change overload Add first class mixins to embedded sass protobuf and JS API (sass#3674) Draft 1.1 changes for Color spaces JS API (sass#3704) Add support for the relative color syntax from CSS Color 5 (sass#3676) Bump tj-actions/changed-files from 39.0.3 to 39.2.0 (sass#3697) Package Importer updates (sass#3699) Fix link in Contributing docs (sass#3705)
nex3
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3626 and sass/dart-sass#2073