Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs for pulling the @font-face at-rule to root. #1884

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Specs for pulling the @font-face at-rule to root. #1884

merged 4 commits into from
Mar 2, 2023

Conversation

Goodwine
Copy link
Member

@Goodwine Goodwine commented Mar 1, 2023 •
edited

[skip dart-sass]

See: sass/dart-sass#1899

@Goodwine Goodwine mentioned this pull request Mar 1, 2023
Merged
@Goodwine Goodwine requested a review from nex3 March 1, 2023 07:06
nex3
nex3 requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add tests for it coming through a nested @import and meta.load-css()?

@Goodwine Goodwine requested a review from nex3 March 2, 2023 00:58
@Goodwine
Copy link
Member Author

Goodwine commented Mar 2, 2023

Tests added, PTAL

@Goodwine Goodwine merged commit 6887adb into main Mar 2, 2023
@Goodwine Goodwine deleted the fontface branch March 2, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Goodwine @nex3