Fix for broken Azure Threads url #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 24 24
Lines 1347 1353 +6
=======================================
+ Hits 1326 1332 +6
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
@sashabaranov any further comments / issues you'd like to address? |
|
Thank you! |
sashabaranov
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threads API is broken for Azure OpenAI implementation returning a 404 error
Expected URL = https://your_resource_name.openai.azure.com/openai/threads?api-version=2024-02-15-preview
Current URL = https://your_resource_name.openai.azure.com/openai/deployments/UNKNOWN/threads?api-version=2024-02-15-preview
Link to Microsoft docs: https://github.com/MicrosoftDocs/azure-docs/blob/bb63f74fabd8a70267e1ab2960773f706c8c50c3/articles/ai-services/openai/assistants-reference-threads.md
Fix removes /deployments/UNKNOWN/ by using same approach for /models /assistants API
Added unit tests for Azure Threads API
FYI, this fix also addresses same issue with messages & runs APIs