refactor(discord-utilities): switch to jdecked twemoji fork #797
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
vladfrangu
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Please also update https://github.com/sapphiredev/utilities/blob/main/scripts/twemoji-regex-updater.mts so it fetches from the new source!
|
Thank you for your review Vlad! The script was the first thing that I changed and ran it afterwards to update the actual code, since it gets overridden anyway. |
favna
requested changes
Sep 4, 2024
Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl>
vladfrangu
approved these changes
Sep 5, 2024
favna
approved these changes
Sep 5, 2024
favna
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord has switched to using Justine De Caires' (jdecked) Twemoji fork. Justine is an ex-Twitter employee who off the top of my head, used to work on Twemoji but got laid off during the layoffs after Elon bought Twitter/X. Therefore, switching Sapphire's regex to using said fork would be better suited.
Benefits of this change:
Sources:
Discord Previews mentioned the switch back on the 28th of March 2023.
Discord's Twemoji repo is a fork of Justine's fork.