[docs] fix tool name formatting (for supply) to be lowercase to pass … #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fastlane docs unit tests (#21426)
… Xcode 15, and Ruby 3.1 to test envs (#21465) * Remove/replace old Xcode versions not supported by CircleCI anymore. * Add two new macOS environments: Xcode 14 and 15. * Change to Ruby 3.1 because 3.2 is not available. * Remove new Xcode versions so it can be added in a separate PR. * Add missing name and xcode_version. * Fix specs related to upgrade of OpenSSL version on Ruby 3.1. * Upgrade http-cookie to 1.0.5 to support Ruby 3. * Revert "Add missing name and xcode_version." This reverts commit cf56b93. * Revert "Remove new Xcode versions so it can be added in a separate PR." This reverts commit 34741c5. * Move dependency from development to regular one. * Sort dependencies alphabetically. * Update Gemfile.lock after updating gemspec. * RuboCop: apply `Style/FetchEnvVar` rule throughout codebase. https://docs.rubocop.org/rubocop/1.56/cops_style.html#stylefetchenvvar * Update Rubocop from 1.12.1 to 1.56.0 (latest) to support Ruby 3.1. * Regenerate Rubocop TODO file. * Revert "RuboCop: apply `Style/FetchEnvVar` rule throughout codebase." This reverts commit e122484. * Downgrade Rubocop to keep support to Ruby 2.6. * Fix all Rubocop linter issues detected in Plugins templates. * Revert changes to fix dynamic versions used in template. * Remove outdated comment. * Use specific Ruby version to see if CircleCI is able to detect them. * Move rubocop rule to where it's being actually used. * Code style. * Fix syntax. * Massage dependencies versions to resolve compatibility issues. * Revert version bump to keep support for Ruby 2. * Fix rspec crashes when running Ruby 3.2 by upgrading `fakefs` gem. * Move back to Ruby 3.1. * Revert "Fix rspec crashes when running Ruby 3.2 by upgrading `fakefs` gem." This reverts commit fda2881. * Specify full Ruby versions for 2.6 and 2.7. * Temporarily comment out condition to test other Ruby envs. * Revert "Temporarily comment out condition to test other Ruby envs." This reverts commit adac361. * Revert unintentional changes to dependency versions. * Revert unintentional changes to dependency versions.
… tests (#21427) * Update PR template. * Modify wording.
…1478) * Let you specify beta group access to all builds at creation * Add tests for access to all builds
* fix: prevent directory download from s3 * chore: add test to verify file-like s3 downloads * Update match/lib/match/storage/s3_storage.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> --------- Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
* Add minor branding guidelines. * Improve checks on branding style. * Prefer `lowercase` over `lower case`. https://english.stackexchange.com/a/59413 * Adequate existing docs to branding guidelines. * Improve lowercase checking algorithm to cover all wEiRD caSEs. * Improve wording. Co-authored-by: Aaron Brager <getaaron@gmail.com> * Refactor regex to take into account potential false positives. * Add unit tests for the tool name formatting tests. * Use full name for the variable. * Add missing test cases and fix typo in method. * Move test to actual specs. * Run rubocop. * Commit missing part. * Remove emoji indicators. * Remove emoji from specs too 😅 * Use File.readlines instead of File.read + split * Also detect formatting issues at start of line * Fix violations found by new implementation * Add the "features" word back to the table. --------- Co-authored-by: Aaron Brager <getaaron@gmail.com> Co-authored-by: Olivier Halligon <olivier@halligon.net>
… before submitting the app (#20515) * validate the status of app version to be ready_for_review before submitting the app * only retries at most 10 times
* [supply] Implement screenshots upload sync Compare the checksum of the images to be uploaded with the ones already in remote, and skip upload if they already match * Add unit tests * Improve YARD doc * fix typo in comment * Apply suggestions from code review Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Remove redundant condition * Add assertion about not deleting _all_ screenshots when `sync_image_upload` is set --------- Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
* Add request retry with backoff when encountring 429 errors * Fix lint errors --------- Co-authored-by: Josh Holtz <me@joshholtz.com>
…e failed Google API calls (#21518) * [supply] add new SUPPLY_UPLOAD_MAX_RETRIES env var to attempt to solve failed Google API calls * Rewrite expectation to ensure SUT is interrupted by raised error Otherwise if we just `expect(UI).to receive(:user_error!).with(…)` that will mock the `UI.user_error` call in the method being tested... and thus not make it `raise` anymore, which the rest of the implementation of that method will continue executing when run in the context of mocked tests while it would not in the real world, which means we would be testing a different behavior of the method --------- Co-authored-by: Olivier Halligon <olivier@halligon.net>
…ario of having both macOS and iOS apps present (#21472) * Fetch live app info if no edit info is present * Add comments to explain the fallback * Check App Info localization only when new metadata contains App Info * Fix lint issues * Only fail upload when trying to update localised app info in no edit mode. * Update tests * Make rubocop happy * Update deliver/lib/deliver/upload_metadata.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Update deliver/lib/deliver/upload_metadata.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Update deliver/lib/deliver/upload_metadata.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Update message severity * Minimize api call to fetch app infos * Add tests * Fix simple typos. * Refactor to more Ruby-like syntax Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Update tests * Update spelling for consistency Co-authored-by: Olivier Halligon <olivier@halligon.net> * Update spelling for consistency Co-authored-by: Olivier Halligon <olivier@halligon.net> * Address feedback * Update user-facing message. * Fix syntax of string quotes. --------- Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> Co-authored-by: Olivier Halligon <olivier@halligon.net>
…21554) * feat(snapshot): Add support for new Apple devices - Introduce iPhone 14 & 15 series - Add Apple Watch Series 5, 6, 7, 9, and Ultra 2 - Incorporate iPad Pro 4th & 6th gen - Include Apple TV 4K 3rd gen * feat(snapshot): Add iPhone 14 Pro support and update tests * Revert "feat(snapshot): Add iPhone 14 Pro support and update tests" This reverts commit e11dd08.
…21428) * Added selection certificate and key by ENV MATCH_CERTIFICATE_ID * Fixed env var description * Renamed vars from select_cert_or_key method
…fo (#21553) * capturing NoMethodError exception * force retrigger circleci build
…ot Reports (#21557) * Add missing newer iPhone models to Generated Snapshot Reports * Add missing iPad versions as well * Fix accidental duplicate * Fix iPad order
* Add multiplatform example project * Add multiplatform? predicate to Project * Detect when a multiplatform project is being built for a particular platform * Rubocop fixes * Update to latest version of xcodeproj Ensure fastlane can parse Xcode 14 projects
…crash in Xcode 15 when running in Apple Silicon (#21493) * Since url is the property we're trying to append to failure message, check for it speficially * Add test to verify we still get useful test failure data without document location data * We don't like the dig here, message received * ping * clean up mock * ping for ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fastlane docs unit tests (fastlane#21426)
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Testing Steps