Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix community cookie store links #360

Closed
wants to merge 1 commit into from

Conversation

sequencerr
Copy link

No description provided.

Copy link

Thanks for the contribution! Before we can merge this, we need @sequencerr to sign the Salesforce Inc. Contributor License Agreement.

README.md Show resolved Hide resolved
- [`redis-cookie-store`](https://github.com/benkroeger/redis-cookie-store): Redis
- [`tough-cookie-filestore`](https://github.com/mitsuru/tough-cookie-filestore): JSON on disk
- [`tough-cookie-web-storage-store`](https://github.com/exponentjs/tough-cookie-web-storage-store): DOM localStorage and sessionStorage
- [`tough-cookie-file-store`](https://github.com/ivanmarban/tough-cookie-file-store): JSON on disk
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -475,10 +475,9 @@ A just-in-memory CookieJar synchronous store implementation, used by default. De
These are some Store implementations authored and maintained by the community. They aren't official and we don't vouch for them but you may be interested to have a look:

- [`db-cookie-store`](https://github.com/JSBizon/db-cookie-store): SQL including SQLite-based databases
- [`file-cookie-store`](https://github.com/JSBizon/file-cookie-store): Netscape cookie file format on disk
- [`file-cookie-store`](https://github.com/therootcompany/file-cookie-store): Netscape cookie file format on disk
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sequencerr
Copy link
Author

image
image
#297 (comment)
#261 (comment)
Guys, you need to fix this.

@colincasey
Copy link
Contributor

@sequencerr Sorry about that. We're looking into why the CLA signing status checks aren't updating.

Copy link
Contributor

@colincasey colincasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updated links @sequencerr.

@colincasey
Copy link
Contributor

@awaterma @wjhsf mind giving this a review?

@wjhsf
Copy link
Contributor

wjhsf commented Feb 21, 2024

Replaced by #367.

@wjhsf wjhsf closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants