Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial documentation review #234

Merged
merged 12 commits into from May 24, 2022
Merged

Initial documentation review #234

merged 12 commits into from May 24, 2022

Conversation

mcarey86
Copy link
Contributor

@mcarey86 mcarey86 commented Mar 7, 2022

No description provided.

colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
colincasey
colincasey reviewed Mar 8, 2022
View reviewed changes
README.md Show resolved Hide resolved
@colincasey colincasey mentioned this pull request Mar 21, 2022
Closed
@wjhsf wjhsf mentioned this pull request Apr 7, 2022
Closed
wjhsf
wjhsf previously approved these changes Apr 7, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mcarey86 and others added 5 commits May 23, 2022 10:13
@mcarey86 @wjhsf
Update README.md
9a98574 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@mcarey86 @wjhsf
Update README.md
bad13a4 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@mcarey86 @wjhsf
Update README.md
e6560e2 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@mcarey86 @wjhsf
Update README.md
3875186 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
@mcarey86 @wjhsf
Update README.md
de40b7f 
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
wjhsf
wjhsf previously approved these changes May 23, 2022
View reviewed changes
awaterma
awaterma reviewed May 23, 2022
View reviewed changes
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one minor comment regarding expiryTime(); outside of that looks good to me!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
awaterma
awaterma approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wjhsf wjhsf merged commit b8d7511 into salesforce:master May 24, 2022
@wjhsf wjhsf mentioned this pull request May 24, 2022
Open
@Silverium Silverium mentioned this pull request Aug 26, 2023
Open
wjhsf pushed a commit that referenced this pull request Feb 8, 2024
@jodarove
revert(apex-methods-automock): reverts functionality providing apex a…
f8586d5 
…utomocks (#234)

fixes #232

This PR reverts #231, #210, and #208. They provided functionality to auto mock apex methods.

**Note:** Test authors will need to keep implementing their own apex (+apexContinuation) methods mocks after this PR is merged.

* Revert "fix: apex automock should return a resolved promise (#231)"

This reverts commit 544f95a.

* Revert "fix: add apex stubs to the transformIgnorePatterns (#210)"

This reverts commit fe8381a.

* Revert "fix: automock apex methods with valid wire adapters (#208)"

This reverts commit 125c689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colincasey colincasey colincasey left review comments

@awaterma awaterma awaterma approved these changes

@wjhsf wjhsf wjhsf approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcarey86 @colincasey @awaterma @wjhsf