Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test cases for allowSpecialUseDomain option #225

Merged
merged 2 commits into from Dec 20, 2021

Commits on Nov 14, 2021

  1. Unit test cases for allowSpecialUseDomain option

    This PR adds test cases for the `allowSpecialUseDomain` option introduced in [PR salesforce#173](salesforce#173).  The special use domain check was changed to be a refinement on the public suffix check since both setting and retrieving cookies can fail since not all special use domains are considered public suffixes.
    
    The following cases are tested:
    * when the cookie jar is configured with `allowSpecialUseDomain=true`, the code will skip the lookup of a public suffix when a special use domain is detected
    * when the cookie jar is configured with `allowSpecialUseDomain=false`, the code will raise an error describing proper usage when a special use domain is detected
    colincasey committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    cf663a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Configuration menu
    Copy the full SHA
    c615d9f View commit details
    Browse the repository at this point in the history