Add explanation and more special-use domains #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #174
I think @ruoho said he'd write a test case for #173 - once that is in I'll rebase off of that and add some more tests.
The hack in https://github.com/salesforce/tough-cookie/blob/master/lib/permuteDomain.js#L41 was introduced in #173 and is expanded in this PR because we rely on PSL's
psl.get()call. This doesn't work for special-use domains because most of them are not in the Public Suffix List (except for.onion). Interestingly,libpsl(the C equivalent of the PSL js library we use) has aisCookieDomainAcceptable()function that would be useful - I raised an issue asking if there's interest in it for the PSL js library here: lupomontero/psl#232