Missing param validation issue145

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.
 
+## 4.X.X
+
+### Mintor Changes
+- Added in parameter checking to setCookie to error out when no URL was passed in
+
 ## 4.0.0
 
 ### Breaking Changes (Major Version)

lib/cookie.js

@@ -1077,6 +1077,13 @@ class CookieJar {
 
   setCookie(cookie, url, options, cb) {
     let err;
+
+    if (typeof(url) === "function") {
+      cb = url
+      err = new Error("No URL was specified");
+      return cb(err);
+    }
+
     const context = getCookieContext(url);
     if (typeof options === "function") {
       cb = options;

test/cookie_jar_test.js

@@ -669,4 +669,21 @@ vows
       }
     }
   })
+  .addBatch({
+    "Issue #145 - Missing parameter validation on setCookie function causes TypeError": {
+      "with missing parameters": {
+        topic: function() {
+          const jar = new tough.CookieJar();
+          jar.setCookie(
+            new String("x=y; Domain=example.com; Path=/"),
+            this.callback
+          );
+        },
+        "results in a error being returned because of missing parameters": function(err, cookies) {
+          assert(err != null);
+          assert.equal(err.message, "No URL was specified");
+        }
+      }
+    }
+  })
   .export(module);