Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CHANGELOG.md #189

Merged
merged 2 commits into from Mar 27, 2020
Merged

Create CHANGELOG.md #189

merged 2 commits into from Mar 27, 2020

Conversation

ShivanKaul
Copy link
Contributor

Better late than never 馃槃

Better late than never 馃槃
@grantila
Copy link

Great! But it would be nice to know why major, i.e. what are the breaking changes.

Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps breakdown the changelog into "Major" and "Minor" sections for a version change.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated
Comment on lines 7 to 12
- SameSite cookie support
- Cookie prefix support
- Support for promises
- Use ESLint and Prettier to apply consistent, modern formatting
- '.local' support
- Numerous bug fixes!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- SameSite cookie support
- Cookie prefix support
- Support for promises
- Use ESLint and Prettier to apply consistent, modern formatting
- '.local' support
- Numerous bug fixes!
### Minor Changes
- SameSite cookie support
- Cookie prefix support
- '.local' support
- Numerous bug fixes!

@awaterma
Copy link
Member

@ShivanKaul -- let me know what you think; perhaps there's an even better way to setup our changelog.

I wonder if we should also consider adding something like this as a Githook?

Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for working on this @ShivanKaul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants