Fix permuteDomain with trailing dot (#216)

Co-authored-by: Andrew Waterman <65307+awaterma@users.noreply.github.com>
salesforce · Sep 27, 2021 · e66a8b1 · e66a8b1
1 parent 23bd608
commit e66a8b1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/permuteDomain.js b/lib/permuteDomain.js
@@ -68,6 +68,11 @@ function permuteDomain(domain, allowSpecialUseDomain) {
     return [domain];
   }
 
+  // Nuke trailing dot
+  if (domain.slice(-1) == ".") {
+    domain = domain.slice(0, -1)
+  }
+
   const prefix = domain.slice(0, -(pubSuf.length + 1)); // ".example.com"
   const parts = prefix.split(".").reverse();
   let cur = pubSuf;

diff --git a/test/domain_and_path_test.js b/test/domain_and_path_test.js
@@ -194,6 +194,16 @@ vows
             "foo.bar.example.localduhmain"
           ]);
         }
+      },
+      "trailing dot": {
+        topic: tough.permuteDomain.bind(null, "foo.bar.example.com."),
+        "got three things": function(list) {
+          assert.deepEqual(list, [
+            "example.com",
+            "bar.example.com",
+            "foo.bar.example.com"
+          ]);
+        }
       }
     },
     permutePath: {