Merge pull request #196 from vsin12/checkForEmptyCookie

Returned null in case of empty cookie value
salesforce · Feb 16, 2021 · 65e9a52 · 65e9a52
2 parents 5ae97c6 + 7e2c51b
commit 65e9a52
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/cookie.js b/lib/cookie.js
@@ -1100,8 +1100,13 @@ class CookieJar {
       cb = options;
       options = {};
     }
+
     validators.validate(validators.isFunction(cb), cb);
 
+    if(!validators.isNonEmptyString(cookie) && !validators.isObject(cookie) && ( cookie instanceof String && cookie.length == 0)) {
+      return cb(null);
+    }
+
     const host = canonicalDomain(context.hostname);
     const loose = options.loose || this.enableLooseMode;
 

diff --git a/test/cookie_jar_test.js b/test/cookie_jar_test.js
@@ -699,4 +699,21 @@ vows
       }
     }
   })
+  .addBatch({
+    "Issue #197 - CookieJar().setCookie crashes when empty cookie is passed": {
+      "with missing parameters": {
+        topic: function() {
+          const jar = new tough.CookieJar();
+          jar.setCookie(
+            '',
+            "https://google.com",
+            this.callback
+          );
+        },
+        "results in a error being returned because of missing parameters": function(err, cookies) {
+          assert(cookies == undefined);
+        }
+      }
+    }
+  })
   .export(module);