Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ssr): use import helpers #4724

Merged
merged 3 commits into from
Oct 29, 2024
Merged

refactor(ssr): use import helpers #4724

merged 3 commits into from
Oct 29, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Oct 29, 2024

Details

Doing unrelated work, I noticed that we have an import helper that we don't use! So I used it. I also gave it an easier to use signature.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

wjhsf added 2 commits October 29, 2024 14:36

Verified

This commit was signed with the committer’s verified signature.
wjhsf Will Harney

Verified

This commit was signed with the committer’s verified signature.
wjhsf Will Harney
@wjhsf wjhsf requested a review from a team as a code owner October 29, 2024 18:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…or-of.ts
@nolanlawson nolanlawson merged commit aa49145 into master Oct 29, 2024
11 checks passed
@nolanlawson nolanlawson deleted the wjh/ssr-imports branch October 29, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants