test(ssr): add more stylesheet fixtures #4566
Merged
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Sep 19, 2024
| static renderMode = 'light'; | ||
|
|
||
| render() { | ||
| return template; |
There was a problem hiding this comment.
Asserting that we understand that scoped styles are associated with this template which is returned dynamically from the render function.
nolanlawson
commented
Sep 19, 2024
| </style> | ||
| <style class="lwc-1rssj1tib70" type="text/css"> | ||
| :dir(ltr) {margin-right: 0;}:host {color: blue;} | ||
| </style> |
There was a problem hiding this comment.
It's always :host and :dir() in shadow DOM because we don't support synthetic shadow.
nolanlawson
commented
Sep 20, 2024
| </style> | ||
| <style class="lwc-1rssj1tib70" type="text/css"> | ||
| :dir(ltr) {margin-right: 0;}.lwc-1rssj1tib70-host {color: blue;} | ||
| </style> |
There was a problem hiding this comment.
It's always :dir() because we don't support synthetic shadow, but light DOM gets the "fake" :host when using scoped styles only.
ekashida
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is setting up some work I'm doing to make stylesheets / stylesheet scope tokens work in the new SSR compiler.
This just adds some tests to assert how the existing
@lwc/engine-serverbehaves.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?