feat(engine): add tooltips for performance timings #4541
Merged
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a small follow-up to #4511: it adds tooltips that are visible when hovering over the custom timings in DevTools.
It seems to me that the main benefit of these tooltips is to merely recapitulate the same name as the slice (this is what a lot of the other tooltips in the DevTools UI do). I personally find it annoying to have to zoom in to read the full text, so it's nice to be able to see it without zooming.
These tooltips are pretty minimal because I didn't want to clutter the UI – they mostly just repeat the slice names while adding a hint of context.
The next PR would be to add mutation tracking so that we can report why a component re-rendered (#4542), but I think this may be a bit trickier so I am holding off for now.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
New DevTools visualizations! In dev mode only.