fix: assert we do not traverse past the root #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Apr 30, 2024
| // walk up | ||
| node = getParentNode(node); | ||
| } | ||
| // we never want to walk right from the root | ||
| assertNotRoot(node); |
There was a problem hiding this comment.
Note I have a similar PR forthcoming for @lwc/synthetic-shadow that demonstrates that it is possible to mistakenly traverse right from the root in this algorithm. But in these tests this case is not possible to hit.
ekashida
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
After implementing #4181, I realized there is one possible case where we could incorrectly generate the static parts, and thus we should add an assertion here as well.
The case is where the root of the static tree is not the ultimate root, and it has a right sibling. In that case, we would incorrectly traverse to the right of the root.
(Note this is impossible today because we generate the static parts correctly in
@lwc/template-compiler; this is just an assert to ensure we never make this mistake in the future.)Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?