feat!: @W-17529338 reformat SSR rules to support eslint v9 #180
+57
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravijayaramappa
previously requested changes
Jan 3, 2025
lib/rules/ssr/ssr-no-form-factor.js
Outdated
| @@ -16,7 +16,7 @@ module.exports = { | |||
| docs: { | |||
| description: 'Discourage use of formFactor.', | |||
| category: 'LWC', | |||
| url: docUrl('ssr/no-form-factor'), | |||
| url: docUrl('docs/rules/ssr/ssr-no-form-factor'), | |||
There was a problem hiding this comment.
docs/rules/ is prepended by docUrl routine. Same comment for all the other docUrls changes below.
Suggested change
| url: docUrl('docs/rules/ssr/ssr-no-form-factor'), | |
| url: docUrl('ssr/ssr-no-form-factor'), |
There was a problem hiding this comment.
Fixed it myself and requested @nolanlawson to review and approve.
nolanlawson
approved these changes
Jan 3, 2025
ravijayaramappa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to update the format of ssr rules as in eslint v9 '/' is no longer valid in rule id.
To maintain uniformity of ssr rules they have been prefixed with 'ssr-'
Without this change, eslint v9 update is blocked as the rules cannot be configured in eslint-config-lwc. It results in the error as shown below:
Follow up to #170
BREAKING CHANGE: The ssr related rules will be renamed from
@lwc/lwc/ssr/no-xxxto@lwc/lwc/ssr-no-xxx