Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/boost_cropped: Switch upstream to scipy, update to 1.75.0 #35807

Closed
wants to merge 1 commit into from

Conversation

mkoeppe
Copy link
Member

@mkoeppe mkoeppe commented Jun 22, 2023

πŸ“š Description

https://github.com/scipy/boost-headers-only

Resolves #34748

πŸ“ Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

βŒ› Dependencies

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Documentation preview for this PR (built with commit 4f6f467; changes) is ready! πŸŽ‰

@dcoudert
Copy link
Contributor

This looks good to me. Should we try to do more tests (and how) ?

@dimpase
Copy link
Member

dimpase commented Jul 13, 2023

boost 1.75 is 2.5 years old. The current boost version is 1.82.0.

Why is scipy stuck in 1.75?

@dimpase
Copy link
Member

dimpase commented Jul 13, 2023

anyhow, I reckon that all the platforms we support do ship a new enough boost, so this is a low-priority update of a vendored package.

I'd rather be getting rid of internal boost-cropped. There is always a chance that some Sage package will need more than this from boost, e.g. there are GAP packages which use boost...

@dcoudert
Copy link
Contributor

At least this PR should simplify the management of this package.

@dimpase
Copy link
Member

dimpase commented Jul 13, 2023

I think scipy has more or less abandoned their boost-headers only clone, and instead went with directly vendoring Boost.Math (the only thing they need), cf scipy/scipy#17432

@dcoudert
Copy link
Contributor

oups. So then it's not a good idea to switch to this tarball :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update boost-cropped to 1.82.0
3 participants