CI targeting current JDK

[andrioli]

No description provided.

[andrioli]

Build with JDK >= 12 is failing with some Javadoc or Apache Maven Javadoc Plugin error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (default) on project jaguar2-api: MavenReportException: Error while generating Javadoc: 
Error:  Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
Error:  
Error:  Command line was: /opt/hostedtoolcache/Java_Zulu_jdk/12.0.2-3/x64/bin/javadoc @options @packages
Error:  
Error:  Refer to the generated Javadoc files in '/home/runner/work/jaguar2/jaguar2/jaguar2-api/target/apidocs' dir.

Build with JDK >= 15 is failing with some PMD or Apache Maven PMD Plugin error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.13.0:pmd (pmd) on project jaguar2-api: Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.13.0:pmd failed: org.apache.maven.reporting.MavenReportException: Unsupported targetJdk value '15'. -> [Help 1]

Build with JDK >= 18 is failing with some JaCoCo Maven Plug-in error:

Error:  Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.7:report (report) on project jaguar2-api: An error has occurred in JaCoCo report generation.: Error while creating report: Error while analyzing /home/runner/work/jaguar2/jaguar2/jaguar2-api/target/classes/br/usp/each/saeg/jaguar2/spi/SpectrumExporter.class. Unsupported class file major version 62 -> [Help 1]

[andrioli]

Also, just missed that for JDK 21 the fail is related with some error with Animal Sniffer Maven Plugin

Error:  Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.23:check (default) on project jaguar2-api: Failed to check signatures: Bad class file /home/runner/work/jaguar2/jaguar2/jaguar2-api/target/classes/br/usp/each/saeg/jaguar2/api/Heuristic.class: Unsupported class file major version 65 -> [Help 1]

[andrioli]

force-pushed because I had forgotten to update two properties

[andrioli]

I did some commits (477a24f, b48ae5b) to troubleshoot the Javadoc problem but the checks for some JDK versions are failing before Javadoc generation.

JDK >= 18 is failing on JaCoCo report after test execution and JDK 21 is failing after compilation on Animal Sniffer analysis.

let's fix these issues first!

[andrioli]

Okay, now all build for JDK >= 18 is failing on JaCoCo report (including JDK 21).

[andrioli]

force-push only to trigger CI that was not executed!

[andrioli]

now all build for JDK >= 15 is failing on PMD Maven goal. Let's try to fix it!

[andrioli]

Back from my vacations... Let's see what is happening here!

[andrioli]

Looks that the build is working as expected (same result from last commit). So let's try to fix the issues with PMD

[andrioli]

Yay, looks that the problems related to Javadoc (JDK 12, 13 and 14) were also fixed by the previous commit.

[andrioli]

Looks that now we are facing problems with some access restrictions to modules on newer Java versions. Based on the tests that are failing I bet is something related with the version of Mockito we are using (that is very old)

The error is:

Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @55a093de

The weird part is that this errors only showed up now with the current code changes.

[andrioli]

Is definitely something related with JaCoCo 0.8.9. Looks that after downgrade to JaCoCo 0.8.8 the build with JDK 16, 17, 18 and 19 become green. Obviously the build with JDK 20 and 21 is not working as JaCoCo 0.8.8 does not support those bytecode versions.

[andrioli]

After some digging I found it. JaCoCo 0.8.9 fixed an issue that opens java.lang package to unnamed modules

See: jacoco/jacoco#1334 and jacoco/jacoco#1328

Before the fix, JaCoCo was hiding a Mockito issue as module java.base does not opens java.lang to unnamed module and this is required by our version of Mockito.

See: #87

I'll try this workaround before check if update Mockito will do the definitive fix.

[andrioli]

After a deeper inspection on the logs I noticed that PMD is not working for JDK >= 14. This make some sense, since the version of PMD we are using only support Java source code up to version 13. I was expecting it to work if the source was <= 13 but bytecode version >= 14. But didn't work. PMD rely on ASM for type resolution (See: https://pmd.github.io/pmd/pmd_languages_java.html#type-and-symbol-resolution) and the version of ASM does not support class file major version 58 (Java 14).

This is the error found in pmd.xml file when running on my machine with Java 17:

 net.sourceforge.pmd.PMDException: Error while processing /Users/raraujo/dev/repos-saeg/jaguar2/jaguar2-api/src/main/java/br/usp/each/saeg/jaguar2/api/SpectrumEval.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:113)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:89)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:51)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:78)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:24)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 61
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:195)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:176)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:162)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:283)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:110)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1618)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:210)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:118)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:163)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:190)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:107)
	... 10 more

At least the build is green. I hope when upgrade PMD plugin the problem goes away. Maybe we can address this issue whiten #76.