Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare ES module in package.json #1061

Merged
merged 6 commits into from Nov 14, 2023

Commits on Sep 23, 2021

  1. fix: declare ES module in package.json

    In bundler mode, generate the package.json with "type": "module" and use the
    "main" attribute instead of the "module" attribute.
    
    This change makes the built ES module palatable to node in
    --experimental-wasm-modules mode as well as to webpack as illustrated in
    webpack/webpack#14313
    gthb committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    c5298f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Configuration menu
    Copy the full SHA
    384238d View commit details
    Browse the repository at this point in the history
  2. refactor: rename type_ to ty in ESModulesPackage

    I noticed that this specific evasion of the "type" keyword is already used in
    utils::manifest::NpmPackage in the tests, so just match that.
    gthb committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    70be9d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Configuration menu
    Copy the full SHA
    42c8e48 View commit details
    Browse the repository at this point in the history
  2. test: update new test to expect main instead of module

    Update test case that landed after this PR was created, in
    rustwasm#1061, to expect main attribute in
    package.json instead of module attribute.
    gthb committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    4ca0f02 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    473dbf8 View commit details
    Browse the repository at this point in the history