fix(ws): calling close event with destroyed close callback #264
+42
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice the following error:
And it's 100% reproduced when
wasm-pack test --chrome
.It's a racing condition:
Websocket::close
, which consumes the ownership.Websocket::drop
is executed emmediatelyself.ws.close()
the second time (and it doesn't matter).self.ws.onclose
is called with destroyedclose
callback.Solution:
open/close
event listeners once (which I think okay, tell me if not)open/message/error
eventlisteners when droppingclose
event to notify the user (and unbind).