[rfc] Implement an ObjectUrl wrapper #231
Conversation
crates/file/src/object_url.rs
Outdated
| pub fn new(target: &dyn ObjectUrlTarget) -> Self { | ||
| Self { | ||
| inner: Rc::new(ObjectUrlAllocation::allocate_new_object_url(target)), | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not just have From impls? From<Blob>, From<File>, etc should be fine. I think it's better to use Rust's traits instead of creating our own, unless we have to.
A macro may be used to make implementing traits easier. Rust's orphan rules will ensure that no more traits can be implemented, effectively sealing it
There was a problem hiding this comment.
For the most part, it's replicating BlobContents. The "overload" here is for the Url::create_object_url method. A potential impl for MediaSource has been omitted because it's deprecated. Should it be added, too?
There was a problem hiding this comment.
For the most part, it's replicating
BlobContents. The "overload" here is for theUrl::create_object_urlmethod.
I didn't know BlobContents also did it. I'd argue that should be changed as well but that's for another PR. From trait can also provide the overload and (imo) is better since it's part of std lib so users are more familiar with it and understand how that overload work. That may also help avoid looking at documentation to see how to construct it since the user can just use Intellisense with the From trait.
A potential impl for
MediaSourcehas been omitted because it's deprecated. Should it be added, too?
Unless someone complains and has a valid use-case, no, let's not add support deprecated APIs.
|
Released in gloo-file v0.2.3 🎉 |
Rationale
The
createObjectUrlAPI is offered by the browser to create URLs from Blobs that are too large to represent as data urls. The resulting url is along the lines ofblob:[origin]://[uuid]. There's a counter partrevokeObjectURLthat releases the URL again. Rust lends itself to an abstraction that automatically revokes the url when it is not need any longer.The API
A
struct ObjectUrlabstracts the allocation of a specific ObjectUrl. It uses reference counting to revoke the Url after the last user drops its use. It can be created from aBlob,Fileor directly from aweb_sys::Blob. ADerefimplemention allows access to the stringly-typed url under-the-hood.