Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Add body() and document_element() getters #161

Merged
merged 1 commit into from Oct 26, 2021

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Oct 26, 2021

Closes #160.

Can you release #159 and this in gloo-utils 0.1.1 / gloo 0.4.1 after merging? :)

@hamza1311 hamza1311 merged commit 5b67085 into rustwasm:master Oct 26, 2021
@hamza1311
Copy link
Collaborator

Can you release #159 and this in gloo-utils 0.1.1 / gloo 0.4.1 after merging? :)

I think adding functions should be a minor version increase and not a patch version increase. Isn't it a little too early for another one of that release

@jplatte
Copy link
Contributor Author

jplatte commented Oct 26, 2021

That logic makes sense after 1.x but I wouldn't consider new features before 1.x to always require breaking-change releases, so the only option would then be to do a "patch" release (not sure whether I'd even call it that).

@jplatte jplatte deleted the document-utils branch October 26, 2021 19:14
@hamza1311
Copy link
Collaborator

That logic makes sense after 1.x but I wouldn't consider new features before 1.x to always require breaking-change releases, so the only option would then be to do a "patch" release (not sure whether I'd even call it that).

I agree. I'll update Yew and if nothing else comes up, I'll publish a new "patch" release

@hamza1311
Copy link
Collaborator

@jplatte done!

Sorry it took me almost a month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add document_body and document_element to gloo_utils
2 participants