New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ws): calling close event with destroyed close callback #264

Merged

hamza1311 merged 2 commits into rustwasm:master from flisky:ws-drop-racing

Nov 29, 2022

Contributor

flisky commented Nov 3, 2022 •

edited

I notice the following error:

And it's 100% reproduced when wasm-pack test --chrome.

It's a racing condition:

call Websocket::close, which consumes the ownership.
Websocket::drop is executed emmediately
- call self.ws.close() the second time (and it doesn't matter).
- the closures (event listeners) are dropped (and it matters).
self.ws.onclose is called with destroyed close callback.

Solution:

bindopen/close event listeners once (which I think okay, tell me if not)
unbind the open/message/error eventlisteners when dropping
trigger close event to notify the user (and unbind).

flisky added 2 commits

November 3, 2022 15:42


          chore: cleanup unnessary sender.clone & Rc<closures>

2c7d610


          fix: clear eventListeners when WebSocket::drop

a452f61

hamza1311 merged commit 376aa29 into rustwasm:master

Collaborator

hamza1311 commented Nov 29, 2022

Thanks for the PR! Sorry, took me so long to merge this

flisky deleted the ws-drop-racing branch

January 10, 2023 10:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment