Allow "required if present" EKUs #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Feb 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 97.13% 97.14%
=======================================
Files 19 19
Lines 4333 4336 +3
=======================================
+ Hits 4209 4212 +3
Misses 124 124 ☔ View full report in Codecov by Sentry. |
Using a root certificate in my control to (exclusively) issue code signing certificates. Given the entire purpose of the root is for code signing, I don't really care about the "code signing" EKU on individual certs, but might as well check for it if EKUs are present. |
cpu
reviewed
Feb 7, 2024
djc
approved these changes
Feb 10, 2024
|
@ctz Any interest in reviewing this one or should we merge? |
ctz
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there isn't currently a pub function to use
ExtendedKeyUsage::RequiredIfPresent. Unsure if there was a reason for this, or whether it was just missed?