-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficient handshake extensions experiment #1475
Draft
ctz
wants to merge
7
commits into
main
Choose a base branch
from
jbp-efficient-extensions-experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
- Coverage 95.82% 95.41% -0.42%
==========================================
Files 84 84
Lines 18865 18934 +69
==========================================
- Hits 18077 18065 -12
- Misses 788 869 +81 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 6, 2023
ctz
added
the
performance_enhancement
Pull requests that should improve performance
label
Feb 9, 2024
1 task
Verifying a _received_ `ClientHello` binder should be done against the original received bytes, not our re-encoding of them. This previously worked, because we required and tested that we could round-trip `ClientHello` messages (and others). This is about to become not true.
Instead of `Vec<ClientExtension>`, store the extension data as a struct. This is possible because past commits have removed the need for this us to losslessly round-trip extension data. This involves fewer allocations to construct the extensions for clients. It eliminates repeated iteration of the vector to find specific extensions when processing a `ClientHello` for servers. It also reduces the cost of detecting duplicate extensions.
_Known_ extensions are already checked by code in the previous commit. But we also need to check _unknown_ extensions which are otherwise discarded during decoding.
Use this to send the correct alert for InvalidMessage::PreSharedKeyIsNotFinalExtension
ctz
force-pushed
the
jbp-efficient-extensions-experiment
branch
from
March 13, 2024 13:18
5bc822b
to
dc957ec
Compare
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not worth reviewing yet: CI is unlikely to pass, and i've commented out a slab of tests
this is re #908