Skip to content

Serialize CRL parameters into CertificateRevocationList #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 16, 2024
Merged

Conversation

djc
Copy link
Member

@djc djc commented Mar 8, 2024

Updates the CRL creation flow along the lines of #205.

@djc djc requested review from cpu and est31 March 8, 2024 17:53
@djc djc force-pushed the serialize-crl branch 2 times, most recently from 4bbed8f to 88bb2ae Compare March 8, 2024 21:19
@djc djc force-pushed the serialize-crl branch 2 times, most recently from ed54971 to 8e63b52 Compare March 10, 2024 19:56
@djc
Copy link
Member Author

djc commented Mar 10, 2024

Reviewed the docstrings -- should be better now -- and rebased on top of current main.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks nice to me 👍

@cpu cpu requested a review from est31 March 13, 2024 16:16
@djc djc force-pushed the serialize-crl branch 7 times, most recently from 4aec2a7 to 13dedd2 Compare March 14, 2024 09:38
@djc
Copy link
Member Author

djc commented Mar 14, 2024

Some updates:

  • Rebased
  • Split up two-step CRL serialization commit into a few easier to review parts
  • Made the API more consistent

@est31 est31 added this pull request to the merge queue Mar 16, 2024
Merged via the queue into main with commit cb44be0 Mar 16, 2024
42 checks passed
@est31 est31 deleted the serialize-crl branch March 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants