Skip to content

Apply most Clippy suggestions #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Apply most Clippy suggestions #239

merged 8 commits into from
Mar 8, 2024

Conversation

djc
Copy link
Member

@djc djc commented Mar 8, 2024

I temporarily disabled the #![allow(clippy::complexity, clippy::style, clippy::pedantic)] directive and implemented all the suggestions that I thought improved the code.

@djc djc requested review from cpu and est31 March 8, 2024 12:39
@djc djc force-pushed the clippy-suggestions branch from c4b674f to 4a3f481 Compare March 8, 2024 12:40
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok except for the new -> default change. new is nicer than the longer function name. Also don't like the deprecation. One can implement default though as an alternative.

@djc djc force-pushed the clippy-suggestions branch from 4a3f481 to 62bccab Compare March 8, 2024 17:07
@djc djc added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit bbb9ed9 Mar 8, 2024
@djc djc deleted the clippy-suggestions branch March 8, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants