-
Notifications
You must be signed in to change notification settings - Fork 118
add support for other oid in the extended key usage #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for other oid in the extended key usage #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok except the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Are there any blockers for this PR to be merged? |
It needs to be rebased on |
I think the "Check semver compatibility" job won't resolve because this PR indeed add a variant to a non-exhaustive |
I believe it will resolve because |
18db44b
to
a1f1927
Compare
a1f1927
to
9da3d5b
Compare
As stated in RFC 5280§4.2.1.12 in
This corresponds to the other variant of the x509_parser::extensions::ExtendedKeyUsage
This PR add support for others oid in the extended key usage.