Skip to content

add support for other oid in the extended key usage #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Tudyx
Copy link
Contributor

@Tudyx Tudyx commented Jan 14, 2024

As stated in RFC 5280§4.2.1.12 in

Key purposes may be defined by any organization with a need. Object
identifiers used to identify key purposes MUST be assigned in
accordance with IANA or ITU-T Recommendation X.660 [X.660].

This corresponds to the other variant of the x509_parser::extensions::ExtendedKeyUsage

This PR add support for others oid in the extended key usage.

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok except the comment

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stormshield-gt
Copy link
Contributor

Are there any blockers for this PR to be merged?

@cpu
Copy link
Member

cpu commented Jan 17, 2024

Are there any blockers for this PR to be merged?

It needs to be rebased on main and then I think the "Check semver compatibility" CI task failure will resolve and it could be merged.

@stormshield-gt
Copy link
Contributor

I think the "Check semver compatibility" job won't resolve because this PR indeed add a variant to a non-exhaustive enum. As we have already breaking change in the main branch, I think it's fine.

@cpu
Copy link
Member

cpu commented Jan 17, 2024

I believe it will resolve because main incremented the crate version to 0.13.0 alongside introducing the breaking changes. Since that version isn't released, adding more breaking changes won't trip the semver checks.

@Tudyx Tudyx force-pushed the add_support_for_oid_in_extended_key_usage branch from 18db44b to a1f1927 Compare January 17, 2024 15:06
cpu
cpu previously approved these changes Jan 17, 2024
@cpu cpu dismissed their stale review January 17, 2024 15:08

Build errs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Tudyx Tudyx force-pushed the add_support_for_oid_in_extended_key_usage branch from a1f1927 to 9da3d5b Compare January 17, 2024 15:15
@cpu cpu enabled auto-merge January 17, 2024 15:21
@cpu cpu added this pull request to the merge queue Jan 17, 2024
Merged via the queue into rustls:main with commit 62f796a Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants