Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer aws-lc-rs over ring if both are enabled #252

Merged
merged 2 commits into from Mar 24, 2024
Merged

Prefer aws-lc-rs over ring if both are enabled #252

merged 2 commits into from Mar 24, 2024

Conversation

djc
Copy link
Member

@djc djc commented Mar 20, 2024

Fixes #243.

@djc djc requested review from cpu and est31 March 20, 2024 14:43
@djc djc mentioned this pull request Mar 20, 2024
@djc
Copy link
Member Author

djc commented Mar 24, 2024

@est31 friendly ping? I think this is the last blocker for the release.

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@est31 est31 enabled auto-merge March 24, 2024 17:39
@est31 est31 disabled auto-merge March 24, 2024 18:48
@est31 est31 merged commit 7d895c9 into main Mar 24, 2024
41 of 42 checks passed
@est31 est31 deleted the prefer-aws branch March 24, 2024 18:48
@est31
Copy link
Member

est31 commented Mar 25, 2024

Merged this via a squash merge because some CI job was never successful.

Alvenix pushed a commit to Alvenix/rcgen that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

figure out something for aws_lc_rs's superset of features
3 participants