Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.0 release planning #236

Closed
sigoden opened this issue Mar 7, 2024 · 10 comments
Closed

0.13.0 release planning #236

sigoden opened this issue Mar 7, 2024 · 10 comments

Comments

@sigoden
Copy link

sigoden commented Mar 7, 2024

There are two updates that are very important to me, I hope to see the new release soon.

  1. Use ring@0.17. rcgen@0.12.1 still has a dependency on ring@0.16
ring v0.16.20
└── x509-parser v0.15.1
     └── rcgen v0.12.1
  1. RSA support

Thank you all.

@djc
Copy link
Member

djc commented Mar 7, 2024

I think it would be great to release -- I think it would be nice to get #233 and #223 in, though.

@djc djc changed the title New release planning? 0.13.0 release planning Mar 7, 2024
@est31
Copy link
Member

est31 commented Mar 7, 2024

FTR the way x509-parser 0.15.1 depends on old ring is through a direct dependency, not because it depends on rcgen. That would be a circular dependency which Cargo doesn't allow (outside of dev dependencies but this isn't the case here).

I think it would be great to release -- I think it would be nice to get #233 and #223 in, though.

I agree, IMO it's a good moment to release, we've had multiple larger changes and fully moving to newest ring is a good motivation.

@cpu
Copy link
Member

cpu commented Mar 19, 2024

I think once #241 lands we should consider cutting the release. #242 looks like it could use more time (not yet approved, no tests).

@djc
Copy link
Member

djc commented Mar 19, 2024

Makes sense. Maybe we can do some renaming in advance of #242 so that #242 will be non-breaking?

@cpu
Copy link
Member

cpu commented Mar 19, 2024

Maybe we can do some renaming in advance of #242 so that #242 will be non-breaking?

I'm supportive of the idea but I'm not sure I know what you have in mind. #242 doesn't seem to change any existing fns, but introduces new ones (KeyPair::from_pem_and_sign_algo_with_more_formats, KeyPair::from_der_and_sign_algo_with_more_formats). It doesn't seem breaking to me, or I'm overlooking where some staged renaming will help.

@djc
Copy link
Member

djc commented Mar 19, 2024

I didn't like those APIs so there is a different proposal in the comments.

@cpu
Copy link
Member

cpu commented Mar 19, 2024

I didn't like those APIs so there is a different proposal in the comments.

Aha! Thanks, I understand the proposal now.

@cpu
Copy link
Member

cpu commented Mar 20, 2024

I think we're ready to prepare a release now? 🤞 It looks like #250 could be handled in a follow-up point release w/o semver complication.

@djc
Copy link
Member

djc commented Mar 20, 2024

I think we'd like to get #252 in, but after that I guess we're ready.

@cpu
Copy link
Member

cpu commented Mar 28, 2024

rcgen 0.13 was published this morning, and uses x509-parser 0.16.

@cpu cpu closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants