add WriteBufferManager support #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitmeriaux
force-pushed
the
benoit.meriaux/add-write-buffer-manager-support
branch
from
5125e55
to
2a91da0
Compare
|
@aleksuss could you accept the workflow so I know if everything is ok and take a look, please ? |
aleksuss
reviewed
Jan 5, 2024
aleksuss
reviewed
Jan 5, 2024
|
gentle bump on this @aleksuss to run the workflow :) |
There is still some clippy warning, please run clipppy locally to fix all the errors |
|
rustfmt is now failing because of changes done by clippy 🤔 |
|
@stanislav-tkach could you take a look, please ? |
aleksuss
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add WriteBufferManager support, which was recently added in rocksdb C API with facebook/rocksdb#11710 and facebook/rocksdb#12007