Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose compact_on_deletion_collector_factory #838

Merged

Conversation

zaidoon1
Copy link
Contributor

@zaidoon1 zaidoon1 commented Nov 26, 2023

fixes #718

Copy link
Member

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, but could you please add a simple test for this method?

@zaidoon1 zaidoon1 force-pushed the zaidoon/expose-compact-on-deletion branch from d9270bf to 0a25f41 Compare November 26, 2023 23:41
@zaidoon1
Copy link
Contributor Author

Looking good to me, but could you please add a simple test for this method?

done

@zaidoon1
Copy link
Contributor Author

would be great if we can get this merged please.

@aleksuss aleksuss merged commit 9c847b1 into rust-rocksdb:master Nov 30, 2023
7 checks passed
zaidoon1 added a commit to zaidoon1/rust-speedb that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lack of 'rocksdb_options_add_compact_on_deletion_collector_factory'
3 participants