Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose set_optimize_filters_for_memory #827

Merged
merged 1 commit into from
Oct 25, 2023
Merged

feat: Expose set_optimize_filters_for_memory #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 27 additions & 2 deletions src/db_options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,10 +552,10 @@ impl BlockBasedOptions {

/// Format version, reserved for backward compatibility.
///
/// See full [list](https://github.com/facebook/rocksdb/blob/f059c7d9b96300091e07429a60f4ad55dac84859/include/rocksdb/table.h#L249-L274)
/// See full [list](https://github.com/facebook/rocksdb/blob/v8.6.7/include/rocksdb/table.h#L493-L521)
/// of the supported versions.
///
/// Default: 2.
/// Default: 5.
pub fn set_format_version(&mut self, version: i32) {
unsafe {
ffi::rocksdb_block_based_options_set_format_version(self.inner, version);
Expand Down Expand Up @@ -642,6 +642,31 @@ impl BlockBasedOptions {
ffi::rocksdb_block_based_options_set_checksum(self.inner, checksum_type as c_char);
}
}

/// If true, generate Bloom/Ribbon filters that minimize memory internal
/// fragmentation.
/// See official [wiki](
/// https://github.com/facebook/rocksdb/wiki/RocksDB-Bloom-Filter#reducing-internal-fragmentation)
/// for more information.
///
/// Defaults to false.
/// # Examples
///
/// ```
/// use rocksdb::BlockBasedOptions;
///
/// let mut opts = BlockBasedOptions::default();
/// opts.set_bloom_filter(10.0, true);
/// opts.set_optimize_filters_for_memory(true);
/// ```
pub fn set_optimize_filters_for_memory(&mut self, v: bool) {
unsafe {
ffi::rocksdb_block_based_options_set_optimize_filters_for_memory(
self.inner,
c_uchar::from(v),
);
}
}
}

impl Default for BlockBasedOptions {
Expand Down