Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_ingest_behind ffi call for DB Options #808

Merged
merged 7 commits into from Aug 7, 2023

Conversation

siyuan0322
Copy link
Contributor

I found this option for DB is missing whereas the options of ingest exists in https://github.com/siyuan0322/rust-rocksdb/blob/f8906c39ac26d51b4f5873370c8e214ff86fa02c/src/db_options.rs#L3514

But this ingest option could only be enabled when DB is opened with allow_ingest_behind set to true.

@siyuan0322
Copy link
Contributor Author

Hi guys, I fixed the rustfmt, but this error doesn't appear to be introduced by my PR.

error: package `linux-raw-sys v0.4.5` cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.60.0

@siyuan0322
Copy link
Contributor Author

Regarding the failure in CI, I have submitted another PR #809 to bump up the version of rustc.

@aleksuss
Copy link
Member

aleksuss commented Aug 3, 2023

I guess it's ok to bump the rust version in this PR. And bumping up to 1.63.0 is enough.

@siyuan0322
Copy link
Contributor Author

I guess it's ok to bump the rust version in this PR. And bumping up to 1.63.0 is enough.

Bumped up rustc to 1.63.0

@aleksuss
Copy link
Member

aleksuss commented Aug 3, 2023

Bump here, here and here as well, please.

@siyuan0322
Copy link
Contributor Author

Bump here, here and here as well, please.

Done

@siyuan0322
Copy link
Contributor Author

Well, the CI keeps failing...
This commit fix the clippy, I guess this time it should be green now 😄

@aleksuss aleksuss enabled auto-merge (squash) August 3, 2023 15:56
@siyuan0322
Copy link
Contributor Author

The test may fail due to no space left on device?

cargo:warning=ar: /home/runner/work/rust-rocksdb/rust-rocksdb/target/tests/trybuild/x86_64-unknown-linux-gnu/debug/build/librocksdb-sys-b0837d8a760c5317/out/librocksdb.a: No space left on device

How about remove the target directory after the previous test suite?

@aleksuss
Copy link
Member

aleksuss commented Aug 7, 2023

How about remove the target directory after the previous test suite?

It's a case, but it will increase the time of the CI flow.

@aleksuss aleksuss merged commit b993275 into rust-rocksdb:master Aug 7, 2023
7 checks passed
@siyuan0322 siyuan0322 deleted the zsy/ingest-behind branch August 8, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants