Remove temporary boxed keys in batched_multi_get #801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By forcing the caller to give us an iterator of key references, we can avoid having to clone and allocate one
Box
per input key inbatched_multi_get
, since the keys are already guaranteed to live longer than the function call.This is a slight breaking change, but IMO an acceptable one which should make any users of
batched_multi_get
happy - the only reason to be usingbatched_multi_get
in the first place is to avoid allocations, otherwise one would already use the simplermulti_get
, which allocates for both keys and return values.Examples of breaking changes: