Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose flush_cfs_opt to flush multiple column families #793

Merged
merged 3 commits into from Jun 23, 2023

Conversation

lizhanhui
Copy link
Contributor

which is critically important for atomic flush use case

Fix #792

@daniel-y
Copy link

daniel-y commented Jun 13, 2023

When the atomic flush is enabled, flush_csfs is very useful to flush multiple column families in one call.

Copy link
Member

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple test for this method?

…ically important for atomic flush use case

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@lizhanhui
Copy link
Contributor Author

Can you add a simple test for this method?

Added

@aleksuss aleksuss enabled auto-merge (squash) June 23, 2023 08:15
auto-merge was automatically disabled June 23, 2023 15:38

Head branch was pushed to by a user without write access

@aleksuss aleksuss enabled auto-merge (squash) June 23, 2023 15:41
@aleksuss aleksuss merged commit 023f829 into rust-rocksdb:master Jun 23, 2023
7 checks passed
@lizhanhui lizhanhui deleted the expose_flush_cfs branch June 23, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose rocksdb_flush_cfs API
4 participants