db_options: Expose remaining PlainTableFactoryOptions #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glittershark
force-pushed
the
expose-plain-table-factory-options
branch
from
102029f
to
d5d5f86
Compare
aleksuss
reviewed
Jun 5, 2023
This is intended to go along with facebook/rocksdb#11442.
amartin96
force-pushed
the
expose-plain-table-factory-options
branch
from
d5d5f86
to
3eb64f7
Compare
aleksuss
reviewed
Jul 15, 2023
| /// Used by [`PlainTableFactoryOptions`] | ||
| #[repr(u8)] | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum EncodingType { |
There was a problem hiding this comment.
I guess the EncodingType is a too common name. I would rename it to KeyEncodingType.
Merged
niklasf
added a commit
to niklasf/rust-rocksdb
that referenced
this pull request
Sep 15, 2023
|
Done in #815 |
Shylock-Hg
pushed a commit
to Shylock-Hg/rust-rocksdb
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to go along with
facebook/rocksdb#11442.