rand_jitter v0.4, platform_ns_time feature, MSRV=1.51, rustfmt #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased; no longer uses |
vks
approved these changes
Nov 27, 2023
| @@ -9,6 +9,7 @@ documentation = "https://docs.rs/rand_jitter" | |||
| description = "Random number generator based on timing jitter" | |||
| keywords = ["random", "rng", "os"] | |||
| edition = "2018" | |||
| rust-version = "1.51" | |||
There was a problem hiding this comment.
Would be great to add this to the other Cargo.toml files as well. I'm not sure whether Cargo shipped with Rust 1.36 supports this, but for the other crates it should work.
There was a problem hiding this comment.
That can happen when these get updated... they will need an MSRV update for the next rand_core anyway.
vks
reviewed
Nov 27, 2023
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@1.56.0 # older versions may work (untested) |
There was a problem hiding this comment.
I think 1.36 should work for them.
There was a problem hiding this comment.
We'd have to pin older versions of dependencies (see failure). Doesn't seem worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.
Hacky since it requires a nightly feature. I did try RPIT (return-position impl trait) but rustc still wants a type specification in the test.RPIT does work; Rust was complaining about the (unused) type parameterFon the impl block.Fixes #46: I will release after this is merged.
Apply rustfmt and Clippy to
rand_jitter.Bump MSRV to 1.51 for
rand_jitterand use this version for testing all repo crates. I expect we'll see new versions ofrand_coreand RNGs with a newer MSRV anyway soon(ish) since the Rand repo is already requiring Rust 1.60.