Fix build for wasm32/64-unknown-unknown without std #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
requested changes
Feb 13, 2024
| @@ -30,6 +30,7 @@ js-sys = { version = "0.3", optional = true } | |||
| wasm-bindgen-test = "0.3.18" | |||
|
|
|||
| [features] | |||
| default = ["std"] | |||
| RNG_SOURCE.with(|result| { | ||
| let source = result.as_ref().map_err(|&e| e)?; | ||
| #[cfg(not(std))] | ||
| #[thread_local] |
There was a problem hiding this comment.
#[thread_local] is unstable and even after stabilization will have a very high MSRV.
There was a problem hiding this comment.
Yep, you're right however if I'm not mistaken this is the only alternative for no_std envs
|
Also note that it's fine to pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #394
thread_localattribute for no_std wasm*-unknown-unknown