Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Options API #353

Closed
wants to merge 3 commits into from
Closed

Draft: Options API #353

wants to merge 3 commits into from

Commits on Mar 24, 2023

  1. ci: use minimal permissions for Github Actions 

    Fixes #348

we only need to read the contents of the repo to run our tests, no other
permissions are needed, as we currently do not publish via our CI jobs.

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Mar 24, 2023
    Copy the full SHA
    0b9c0b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Revert Public API of #291 

    Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Mar 25, 2023
    Copy the full SHA
    7f37234 View commit details
    Browse the repository at this point in the history

  2. Draft: Options API 

    Right now we only have a single option `Option::DEFAULT`.

However, in the future, we could add options to:
  - guarantee the function doesn't block
  - use a insecure but quicker system source (for seeding hashmaps).
  - not use a fallback mechanism
  - never use the custom RNG source
  - always prefere the custom RNG source if it exists

Not all of these are things we should _necessarily_ do, but this gives
us the flexibility to add such options in the future.

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Mar 25, 2023
    Copy the full SHA
    06b6850 View commit details
    Browse the repository at this point in the history