Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Edge tests to fail #339

Merged
merged 1 commit into from Feb 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/tests.yml
Expand Up @@ -195,9 +195,8 @@ jobs:
host: x86_64-unknown-linux-musl
- os: windows-2022
host: x86_64-pc-windows-msvc
# Re-enable when Safari tests start working
# - os: macos-12
# host: x86_64-apple-darwin
- os: macos-12
host: x86_64-apple-darwin
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand All @@ -220,11 +219,14 @@ jobs:
run: wasm-pack test --headless --chrome --features=js,test-in-browser
- name: Test (Edge)
if: runner.os == 'Windows'
# Edge has flaky failures: "driver failed to bind port during startup"
continue-on-error: true
run: wasm-pack test --headless --chrome --chromedriver $Env:EDGEWEBDRIVER\msedgedriver.exe --features=js,test-in-browser
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
# - name: Test (Safari)
# if: runner.os == 'macOS'
# run: wasm-pack test --headless --safari --features=js,test-in-browser
- name: Test (Safari)
if: runner.os == 'macOS'
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
continue-on-error: true
run: wasm-pack test --headless --safari --features=js,test-in-browser
- name: Test (custom getrandom)
run: wasm-pack test --node --features=custom

Expand Down