Tests: Use custom tests to verify operations on empty slices are no-ops. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit refactors |
josephlr
reviewed
Oct 21, 2022
There was a problem hiding this comment.
I think this is a good change (both running the common tests and added the empty buffer check). However, is there a reason the code in custom_kat.rs and custom_common/mod.rs can't just be in tests/custom.rs ? Give that we don't reuse the custom code, I'm not sure if splitting up the files makes sense.
josephlr
reviewed
Oct 21, 2022
Modify the custom tests so that they would have detected and prevented the issue fixed in rust-random#298.
briansmith
force-pushed
the
b/is_empty_test
branch
from
302da04
to
bce146d
Compare
|
Closing in favor of #300 PTAL. |
josephlr
added a commit
that referenced
this pull request
Oct 22, 2022
Tests: Use custom tests to verify operations on empty slices are no-ops. Reworking of #299 to keep our custom tests in a single file (and keep things better organized in general).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the custom tests so that they would have detected and prevented the issue fixed in #298.