Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework benchmarks to make it easier to get assembly. #297

Merged
merged 2 commits into from Oct 21, 2022
Merged

Rework benchmarks to make it easier to get assembly. #297

merged 2 commits into from Oct 21, 2022

Commits on Oct 21, 2022

  1. Rename benches/mod.rs to benches/buffer.rs 

    This naming makes more sense, esspecially if we add more benchmark
files.

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Oct 21, 2022
    Copy the full SHA
    359b978 View commit details
    Browse the repository at this point in the history

  2. Rework benchmarks to make it easier to get assembly. 

    This change:
  - Move the benchmarks from mod.rs to buffer.rs
  - Move the inner loop we benchmark into an `#[inline(never)]` function
  - Includes instructions for getting the ASM for a specific benchmark

This should hopefully reduce the variance of these benchmarks and make
it easier to figure out if we are emitting the assembly or IR we expect
for a particular implementation.

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Oct 21, 2022
    Copy the full SHA
    9ac388e View commit details
    Browse the repository at this point in the history