Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for Caching and rustc-dep-of-std feature #198

Merged
merged 2 commits into from Jan 17, 2021
Merged

Add fixes for Caching and rustc-dep-of-std feature #198

merged 2 commits into from Jan 17, 2021

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Jan 14, 2021

We now cache the Cargo index (among other things) in our CI. This prevents some spurious test failures on Windows.

Also, Properly forward rustc-dep-of-std feature

@newpavlov
Copy link
Member

IIRC on aarch64 Hermit simply always returns an error, did this situation change? In other words, any use of HashMap with such code would result in a panic, so the existing exception in the std integration PR looks like a better choice for now. Personally, I would prefer for hermit-os/kernel#143 to be solved first and for getrandom to use the new API.

The CI changes are probably better done in a separate PR.

@newpavlov
Copy link
Member

I like all changes, except the Hermit addition. :) How about removing the Hermit part for now, renaming this PR, and opening a tracking issue for the Hermit part?

@stlankes
Any ETA on adding a Linux-like syscall to Hermit as described in the linked issue?

Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr changed the title Add hermit support Add fixes for Caching and rustc-dep-of-std feature Jan 17, 2021
@josephlr
Copy link
Member Author

I like all changes, except the Hermit addition. :) How about removing the Hermit part for now, renaming this PR, and opening a tracking issue for the Hermit part?

Done. This PR now just contains the caching and rustc-dep-of-std fixes.

@josephlr
Copy link
Member Author

#199 is now open to track all hermit <-> getrandom issues. Further discussion should continue there.

@josephlr josephlr mentioned this pull request Jan 17, 2021
6 tasks
@stlankes
Copy link

A small comment to the ARM port, it comes, but the current version isn't stable. It takes some time.

@josephlr josephlr merged commit 9a48bfa into master Jan 17, 2021
@josephlr josephlr deleted the hermit branch January 17, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants