Skip to content

Commit

Permalink
Allow Edge tests to fail (#339)
Browse files Browse the repository at this point in the history
Window's `msedgedriver` seems to be unreliable, as port binding will
occasionally fail. Instead of wasting time trying to debug this, just
let the tests fail.

We take a similar approch for Safari's webdriver, we will allow the
tests to fail, but will hopefully see when they start succeeding (when
Safari fixes the COOP bug).

Signed-off-by: Joe Richey <joerichey@google.com>
  • Loading branch information
josephlr committed Feb 23, 2023
1 parent 74a2021 commit 41b8981
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions .github/workflows/tests.yml
Expand Up @@ -195,9 +195,8 @@ jobs:
host: x86_64-unknown-linux-musl
- os: windows-2022
host: x86_64-pc-windows-msvc
# Re-enable when Safari tests start working
# - os: macos-12
# host: x86_64-apple-darwin
- os: macos-12
host: x86_64-apple-darwin
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand All @@ -220,11 +219,14 @@ jobs:
run: wasm-pack test --headless --chrome --features=js,test-in-browser
- name: Test (Edge)
if: runner.os == 'Windows'
# Edge has flaky failures: "driver failed to bind port during startup"
continue-on-error: true
run: wasm-pack test --headless --chrome --chromedriver $Env:EDGEWEBDRIVER\msedgedriver.exe --features=js,test-in-browser
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
# - name: Test (Safari)
# if: runner.os == 'macOS'
# run: wasm-pack test --headless --safari --features=js,test-in-browser
- name: Test (Safari)
if: runner.os == 'macOS'
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
continue-on-error: true
run: wasm-pack test --headless --safari --features=js,test-in-browser
- name: Test (custom getrandom)
run: wasm-pack test --node --features=custom

Expand Down

0 comments on commit 41b8981

Please sign in to comment.