Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline attribute to segment functions #430

Merged

Conversation

tsoutsman
Copy link
Contributor

@tsoutsman tsoutsman commented Aug 4, 2023

Continuation of #125 I suppose.

Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@kevinaboos
Copy link
Contributor

kevinaboos commented Aug 4, 2023

To add some context, we noticed this lack of inlining while switching some CPU-local storage code in Theseus OS from using inline assembly to using this crate's segment base register access functions.

Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Looks good to me.

@Freax13 Freax13 enabled auto-merge August 4, 2023 05:04
@Freax13 Freax13 merged commit 5dbcc9f into rust-osdev:master Aug 4, 2023
12 checks passed
@Freax13 Freax13 mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants