Add missing IDT entries #CP and #HV #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the InterruptDescriptorTable is missing entry with vector number 28, #HV. More information at AMD's APM Volume 2, subsection 8.2.21. See issue #377. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Currently the InterruptDescriptorTable is missing entry with vector number 21, #CP. More information at AMD's APM Volume 2, subsection 8.2.20. See issue #378. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Freax13
requested changes
Jul 21, 2022
There was a problem hiding this comment.
Thanks for taking the time to implement this!
Good job on the doc comments, I really like them!
A few more steps are required to fully integrate the new exception vectors:
- For the
IndexandIndexMutimplementations: add cases forhv_injection_exceptionhere and here and cases forcp_protection_exceptionhere and here - For
set_general_handler_entry!: this and this arm must be removed. An arm similar to this must be added forcp_protection_exception(hv_injection_exceptionwill be handled here and doesn't need to be explicitly added) - For the tests: changes are needed here and here
Include the cases for #CP (cp_protection_exception) and #HV (hv_injection_exception) in the Index and IndexMut implementations. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Add the following changes to macro set_general_handler_entry! to account for the newly added vector entries: For #HV (vector 28) we need to remove the empty arm. For #CP (vector 21) we need to remove the empty arm, and include a new arm. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Update tests for IDTs considering newly added vector entries #CP and #HV. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Fix typo in #CP definition. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
The #CP (vector 21) exception can also be generated due to a missing ENDBRANCH instruction if indirect branch tracking is enabled. Include this in the comments. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
Freax13
requested changes
Jul 21, 2022
Make case #CP (21) reachable for Index and IndexMut implementations. Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
|
Thanks for all your feedback, @Freax13. It was very helpful. I think this is ready now :) |
Freax13
approved these changes
Jul 21, 2022
This was
linked to
issues
Jul 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing IDT entries #CP (vector number 21) and #HV (vector number 28) in the InterruptDescriptorTable. Both entries are documented in AMD's APM Volume 2 (here), section 8.2.
This pull request addresses issues #377 and #378.
Signed-off-by: Carlos Bilbao carlos.bilbao@amd.com