deps: bump bitflags from 1.0 to 2.1 #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should hold off on updating bitflags until bitflags/bitflags#320 is resolved, otherwise some of our documentation will disappear. |
|
The documentation bug in bitflags should be fixed with 2.1.0. |
phip1611
force-pushed
the
bitflags-update
branch
from
92c8623
to
fc5f83a
Compare
|
It seems to me that there is a bug with intra-doc links in bitflags. |
phip1611
force-pushed
the
bitflags-update
branch
2 times, most recently
from
48bb44a
to
0a43190
Compare
|
Please review again. |
phip1611
force-pushed
the
bitflags-update
branch
from
0a43190
to
56644e1
Compare
phip1611
commented
Apr 6, 2023
phip1611
force-pushed
the
bitflags-update
branch
from
56644e1
to
63ab362
Compare
phip1611
force-pushed
the
bitflags-update
branch
2 times, most recently
from
8e9358d
to
372ee1b
Compare
phip1611
force-pushed
the
bitflags-update
branch
2 times, most recently
from
1f30421
to
d6f11c8
Compare
|
Something is strange with github.. I can't (force) push.
Will try again in a couple of hours, tho PS: There is a github outage indeed https://www.githubstatus.com/ |
|
I think this is now also ready :) @nicholasbishop |
phip1611
commented
May 9, 2023
phip1611
commented
May 9, 2023
phip1611
commented
May 9, 2023
We skip 2.0.0 as it has a bug and "cargo doc" doesn't include generated documentation.
nicholasbishop
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates bitflags from version 1 to version 2.
TL;DR: Now every struct needs to manually implement copy, clone, partial ord, etc.
Checklist